https://bugs.kde.org/show_bug.cgi?id=425995

--- Comment #6 from Karl Robillard <wickedsm...@users.sf.net> ---
Thanks for the fix, but this seems a rather messy way to go about it.

Since there are no independent default values for the CLI you are forcing the
user to use these options, but that is something they will only discover after
finding out that the behavior is still inconsistent.  It is unfortunate the the
title of the bug was changed from "includeDecorations option makes CLI use
unreliable" as that problem still exists for certain use cases.

Consider this:
  1. User adds a spectacle line to a script without the new options and tests
that it runs as expected (window contents & decorations).
  2. User tweaks the setting in the GUI some days later for another project,
not thinking about the script.
  2. User runs said script a week later and spends time troubleshooting why the
screenshot now has no decorations.

This partial fix not only requires CLI users to use the new options, it appears
that there are no short versions so they must be verbose.

It also appears that these new options are the only ones that have
enable/disable versions, which makes them inconsistent with existing options
such as --gui and --nonotify.  Why are there no opposite options --no-gui or
--notify for those?

Apologies if I misinterpreted what that commit does, but I think that:
  1. There should be default values for the CLI (as is done with -g and -n).
  2. There should be short versions of the options.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to