https://bugs.kde.org/show_bug.cgi?id=427404
--- Comment #6 from Julian Seward <jsew...@acm.org> ---
Functional support fix (attachment 132180) -- OK to land.
--------------------------------------------------------------------
testsuite support for the reduced precision outer product operations
(attachment 132181) -- OK to land.
--------------------------------------------------------------------
functional support ISA 3.1 for reduced precision outer product operations
(attachment 132620)
I have some correctness concerns regarding setup_fxstate_struct and
some other comments.
setup_fxstate_struct: this worries me. It claims that 4 regs are written,
but not read. Is that really correct -- that none of the regs are read?
How can that be useful?
write_ACC_entry
get_ACC_entry
better to crash the system if `acc` or `reg` is out of range, rather than
printing
an error message and continuing incorrectly. Maybe just convert the
if ((acc < 0) || (acc > 7)) {
etc into the relevant assert: vassert(acc >= 0 && acc <= 7) etc
putACC
getACC
similarly, assert if index or reg are invalid.
setup_fxstate_struct
similarly, assert if AT is out of range (+ couldn't you use a switch instead
of a chain of ifs?
dis_vsx_accumulator_prefix
use switch instead of long chain of ifs?
--
You are receiving this mail because:
You are watching all bug changes.
