https://bugs.kde.org/show_bug.cgi?id=428260
Dmitry Kazakov <dimul...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
|hics/krita/commit/062aadf61 |hics/krita/commit/62f487a68
|04d9fb6a84d5a555a7378a551c1 |07f60d0a075deba4a052ebe0a56
|4abe |5802
--- Comment #4 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit 62f487a6807f60d0a075deba4a052ebe0a565802 by Dmitry Kazakov.
Committed on 27/10/2020 at 11:18.
Pushed by dkazakov into branch 'krita/4.3'.
Workaround a deadlock when painting on a vector selection with Instant Preview
Instant Preview is based on running two consequent with different
level of detail, but our vector selection don't support that. More
than that, when starting a paint operation on a vector selection,
it should be flattened into a pixel selection. Which means that in LoD
mode the flattening will happen twice.
Ideally, we should somehow make KisSelection survive flattening in
two separate LoD strokes, but I'm not sure it is really worth the
effort.
The downsides of the patch are:
1) The first painting stroke on a selection based layer or
mask with vector selection will always be executed without
instant preview. It affects all mask, generator layers and
filter layers.
2) The first applicaiton of a filter on such a layer will also
be slow.
CC:kimages...@kde.org
M +5 -0 libs/image/kis_base_node.cpp
M +6 -0 libs/image/kis_base_node.h
M +5 -0 libs/image/kis_mask.cc
M +2 -0 libs/image/kis_mask.h
M +5 -0 libs/image/kis_selection_based_layer.cpp
M +2 -0 libs/image/kis_selection_based_layer.h
M +1 -0 libs/ui/tool/strokes/freehand_stroke.cpp
M +1 -0 libs/ui/tool/strokes/kis_filter_stroke_strategy.cpp
https://invent.kde.org/graphics/krita/commit/62f487a6807f60d0a075deba4a052ebe0a565802
--
You are receiving this mail because:
You are watching all bug changes.
