https://bugs.kde.org/show_bug.cgi?id=428481

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kirigami/commit/b0c4
                   |                            |bc1c41430f7c778e925715d63ed
                   |                            |66fe1ebe0
         Resolution|---                         |FIXED

--- Comment #6 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit b0c4bc1c41430f7c778e925715d63ed66fe1ebe0 by David Edmundson.
Committed on 02/11/2020 at 14:26.
Pushed by davidedmundson into branch 'master'.

Don't alter Item in code called from Item's destructor

QQuickItem::~QQuickItem calls setParentItem(null) before closing

This emits itemChange with ItemRemoved on the column view for that item

We then call ContentItem::forgetItem

And adjust the visibility.

This is problematic as we then start emitting all sorts of things after
our item is being destroyed. Objects monitoring, in this case the
attached accessiblity object can then do something that crash.

The only other caller of forgetItem is the removeItem method, so the
setVisible call is moved there.

Tested by setting up orca
Reproducing crash
Testing fix

M  +1    -1    src/columnview.cpp

https://invent.kde.org/frameworks/kirigami/commit/b0c4bc1c41430f7c778e925715d63ed66fe1ebe0

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to