https://bugs.kde.org/show_bug.cgi?id=427404
Mark Wielaard <m...@klomp.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m...@klomp.org
--- Comment #18 from Mark Wielaard <m...@klomp.org> ---
(In reply to Carl Love from comment #17)
> The following commit was made to fix an issue with the functional support
> ISA 3.1 for reduced precision outer product operations support.
>
> https://sourceware.org/git/gitweb.cgi?p=valgrind.git;
> h=eb82a294573d15c1be663673d55b559a82ca29d3
>
> commit eb82a294573d15c1be663673d55b559a82ca29d3
> Author: Julian Seward <jsew...@acm.org>
> Date: Tue Nov 10 21:10:48 2020 +0100
>
> Add a missing ifdef, whose absence caused build breakage on non-POWER
> targets.
>
> Diff:
> ---
> VEX/priv/guest_ppc_helpers.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/VEX/priv/guest_ppc_helpers.c b/VEX/priv/guest_ppc_helpers.c
> index 45dce63512..ac4d7044a8 100644
> --- a/VEX/priv/guest_ppc_helpers.c
> +++ b/VEX/priv/guest_ppc_helpers.c
> @@ -1112,12 +1112,16 @@ static ULong reinterpret_double_as_long( Double
> input )
>
> static Double conv_f16_to_double( ULong input )
> {
> - // This all seems to be very alignment sensitive??
> - __attribute__ ((aligned (64))) ULong src;
> - __attribute__ ((aligned (64))) Double result;
> - src = input;
> - __asm__ __volatile__ ("xscvhpdp %x0,%x1" : "=wa" (result) : "wa" (src));
> - return result;
> +# if defined(__powerpc__)
> + // This all seems to be very alignment sensitive??
> + __attribute__ ((aligned (64))) ULong src;
> + __attribute__ ((aligned (64))) Double result;
> + src = input;
> + __asm__ __volatile__ ("xscvhpdp %x0,%x1" : "=wa" (result) : "wa" (src));
> + return result;
> +# else
> + return 0.0;
> +# endif
> }
This works for everything except ppc64:
https://builder.wildebeest.org/buildbot/#/changes/1519
Is ppc64 supposed to support xscvhpdp, or is that ppc64le only?
If it depends on the binutils version (the ppc64 setup uses binutils 2.29.1
while the ppc64le setup uses binutils 2.31.1) maybe we need a configure check?
--
You are receiving this mail because:
You are watching all bug changes.
