https://bugs.kde.org/show_bug.cgi?id=427967
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/mult |https://invent.kde.org/mult
|imedia/elisa/commit/3b80b00 |imedia/elisa/commit/b1931eb
|01239f8c6a35f95ff940e6ba596 |86c224c7cdeb1c78fdc4112c214
|075310 |2212d6
--- Comment #5 from Nate Graham <n...@kde.org> ---
Git commit b1931eb86c224c7cdeb1c78fdc4112c2142212d6 by Nate Graham.
Committed on 12/11/2020 at 22:43.
Pushed by ngraham into branch 'master'.
Replace homemade ScrollHelper with standard ScrollViews to hold view items
We created the ScrollHelper component to fix scrolling with touchpads,
which is quite terrible out of the box with QML's default flickables.
However this solution had some drawbacks:
- It broke touch scrolling
- It broke fast scrolling by holding down the shift key while scrolling
- It essentially re-wrote scroll handling locally, which is fragile
- It required a bunch of extra code to handle scrollbar visibility which
introduced various minor visual bugs in a few places
In addition, this solution was not necessary since we can get the
same result by putting views inside ScrollView components, which is a
100% supported and standard paradigm. Doing so preserves the nice
touchpad scrolling we already have but fixes all of the above items
automatically.
Related: bug 417859
FIXED-IN: 20.12
M +0 -1 src/CMakeLists.txt
M +23 -31 src/qml/GridBrowserView.qml
M +28 -36 src/qml/ListBrowserView.qml
M +18 -26 src/qml/MediaTrackMetadataView.qml
M +113 -120 src/qml/PlayListBasicView.qml
M +0 -3 src/qml/PlayListEntry.qml
D +0 -105 src/qml/ScrollHelper.qml
M +80 -82 src/qml/SimplePlayListView.qml
M +36 -52 src/qml/ViewSelector.qml
M +0 -1 src/resources.qrc
https://invent.kde.org/multimedia/elisa/commit/b1931eb86c224c7cdeb1c78fdc4112c2142212d6
--
You are receiving this mail because:
You are watching all bug changes.
