https://bugs.kde.org/show_bug.cgi?id=428909
--- Comment #20 from Mark Wielaard <m...@klomp.org> --- (In reply to Paul Floyd from comment #18) > Created attachment 133799 [details] > Add configure time checking > > This patch now uses configure. The tests are fairly complicated, but seem to > work OK for Fedora 33, Alpine Linux (musl), Solaris 11.3 and FreeBSD. > However, I don't get what I expect for macOS. I only have access to 1 mac > running 10.7 to test this on, and Apple's libc/libpthread are rather > different and change fairly often. > > Bottom line is that I'm not entirely sure that this is better than the > prvious patch. I find the logic in the previous patch much easier to follow. The configure tests look complex/fragile. Also I am not sure the first ac_thread_fns_only_in_libc=yes is correct. Why couldn't those (or other) functions then not also be in libpthread? Normally I would agree with Bart, but I think this is one example of when configure tests are actually harder to keep correct than the simple ifdefs based on platform. -- You are receiving this mail because: You are watching all bug changes.
