https://bugs.kde.org/show_bug.cgi?id=425036

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
                   |ma/plasma-desktop/commit/85 |ma/plasma-desktop/commit/82
                   |00046453ae90862f72049e1a24e |b404b624d32cc3ed0bb03936455
                   |c804ce85cff                 |eb26b99c11d
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #9 from Nate Graham <n...@kde.org> ---
Git commit 82b404b624d32cc3ed0bb03936455eb26b99c11d by Nate Graham, on behalf
of Nicolas Fella.
Committed on 15/01/2021 at 20:44.
Pushed by ngraham into branch 'master'.

[kcm/users] Avoid half transactions when user cancels auth dialog

Not all calls to accountsservice require authentication and once we hit one
that does and the user cancels the prompt then there might be some fields
written already.
This is unexpected for the user since they expect the whole transaction to be
cancelled.

To avoid this move the call to SetAccountType to the front since that will
always trigger a prompt.

It's arguably a workaround for the lack of a transaction concept in
AccountsService, but I don't see a better short-term solution.

M  +65   -56   kcms/users/src/user.cpp
M  +2    -0    kcms/users/src/user.h

https://invent.kde.org/plasma/plasma-desktop/commit/82b404b624d32cc3ed0bb03936455eb26b99c11d

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to