https://bugs.kde.org/show_bug.cgi?id=432215
Mark Wielaard <m...@klomp.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REPORTED |CONFIRMED
Ever confirmed|0 |1
CC| |m...@klomp.org,
| |philippe.waroquiers@skynet.
| |be
--- Comment #1 from Mark Wielaard <m...@klomp.org> ---
Nice. Adding Philippe to CC because he probably knows most about executing
subprocesses from valgrind core.
My first comments would be:
- It would be nice to not even try if the system doesn't have debuginfod-find
installed or if DEBUGINFOD_URLS is not set or empty. You can check the second
with VG_(getenv)("DEBUGINFOD_URLS") and the first by taking out
ML_(find_executable)("debuginfod-find")) from the new function and setting a
static debuginfo_find_path variable in slightly earlier startup code. You would
also set debuginfo_find_path to NULL if DEBUGINFOD_URLS wouldn't be set.
- I think you need to drain stderr first in a while loop before doing the
VG_(waitpid)(pid, NULL, 0); and VG_(read)(out_fds[0], buf, BUF_SIZE); because
based if the user has set DEBUGINFOD_PROGRESS or DEBUGINFOD_VERBOSE stderr can
see a lot of output (stdout is always just the filename if anything was found).
--
You are receiving this mail because:
You are watching all bug changes.
