https://bugs.kde.org/show_bug.cgi?id=388787

Mark Wielaard <m...@klomp.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m...@klomp.org

--- Comment #7 from Mark Wielaard <m...@klomp.org> ---
That is a big patch indeed. But mostly because it also adds support for libcxx
and solaris. It looks good in general I believe.

The ALLOC_or_NULL_ALIGNED now probably needs a ENOMEM check.

The indentation in coregrind/m_scheduler/scheduler.c looks off (tabs vs
spaces?)

I think we need a configure check for whether the c++ compiler supports
-std=c++17 for the testcase.

Don't we also need new builtin_delete_aligned and builtin_vec_delete_aligned to
get the new/malloc/free/delete mismatch correct?

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to