https://bugs.kde.org/show_bug.cgi?id=432215

Mark Wielaard <m...@klomp.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Mark Wielaard <m...@klomp.org> ---
Thanks for adding the documentation, nice to get it in both the manual and the
man page. I tested it on Fedora and Debian using
DEBUGINFOD_URLS=https://debuginfod.elfutils.org/ and it seems to work.

I made a few small changes, added .gitignore entries, removed the extra warning
in the check so it looks less scary and just produces an error and a prereq
skip, turned the read into a while loop, not because I think the results will
really be partial but to keep the length of what was read so we can check for
\n at the end instead of needing to use strchr. I also moved the
find_executable code up into pub_core_pathscan.h so it can be used from
everywhere.

Pushed as:

commit fd4e3fb0ffa3f751f0e7f2e7f4639d4c3773305d (HEAD -> master, origin/master,
origin/HEAD)
Author: Aaron Merey <ame...@redhat.com>
Date:   Thu Feb 18 22:58:25 2021 -0500

    PR432215 Add debuginfod functionality

    debuginfod is an HTTP server for distributing ELF/DWARF debugging
    information.  When a debuginfo file cannot be found locally, Valgrind
    is able to query debuginfod servers for the file using its build-id.

    readelf.c: Add debuginfod_find_debug_file(). Spawns a child process to
    exec `debuginfod-find` in order to query servers for the debuginfo
    file. Also add helper debuginfod_find_path().

    pub_core_pathscan.h: Moved from priv_initimg_pathscan.h in order to use
    VG_(find_executable)() in readelf.c.

    docs: Add information regarding debuginfod to valgrind.1

    memcheck/tests/linux: Add new test debuginfod-check.

    tests/vg_regtest.in: Clear $DEBUGINFOD_URLS before running any tests.

    https://bugs.kde.org/show_bug.cgi?id=432215

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to