https://bugs.kde.org/show_bug.cgi?id=434407

--- Comment #3 from Domenico Panella <pando...@gmail.com> ---
(In reply to Massimiliano L from comment #2)
> (In reply to Domenico Panella from comment #1)
> > Decreasing "font.pixelSize" property 
> > at
> > https://invent.kde.org/plasma/plasma-desktop/-/blob/master/kcms/users/
> > package/contents/ui/UserDetailsPage.qml#L419
> > 
> > from
> > font.pixelSize: Kirigami.Units.gridUnit * 4
> > 
> > to
> > font.pixelSize: Kirigami.Units.gridUnit * 2.5
> > 
> > it looks good for me.
> 
> I understand you propose a change that makes the font smaller but do we
> understand why the font was changeing size compared to the default?

Yeah, the default image is an Item of the "Text" type not Image, whereas
when we select a new image with initial letters from dialog window,
we save it as Image (PNG).
This is the code which saves the image as PNG file
https://invent.kde.org/plasma/plasma-desktop/-/blob/master/kcms/users/package/contents/ui/UserDetailsPage.qml#L424-434

This is the code (kirigami side) which we decide to show Item text (default
case) or image
https://invent.kde.org/frameworks/kirigami/-/blob/master/src/controls/Avatar.qml#L203-249

At the moment i see two potential problems:
1) The letters font is too large when we select the image from window dialog.
(fixed it simply by decreasing it) 
2) If you attentively observe it, the new image is different than default how
it's rendering too. This appears slightly blurry respect the default image.

In my opinion, the default image and the image which we select via window
dialog should be handled at the same way. 
I mean both handled as Image or Text otherwise we will always see the
difference between them.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to