https://bugs.kde.org/show_bug.cgi?id=436958

michael <reeves...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |RESOLVED
   Version Fixed In|                            |1.9.1
      Latest Commit|                            |https://invent.kde.org/sdk/
                   |                            |kdiff3/commit/18d3db26dea57
                   |                            |5c1b8f418d23ccb93ecc9df026f
         Resolution|---                         |FIXED

--- Comment #17 from michael <reeves...@gmail.com> ---
Git commit 18d3db26dea575c1b8f418d23ccb93ecc9df026f by Michael Reeves.
Committed on 13/05/2021 at 20:09.
Pushed by mreeves into branch '1.9'.

Avoid connect issues with NDEBUG beging defined when Qt thinks we're in release
mode.

The offending Qt lines are here:
#if !defined(Q_ASSERT)
#  if defined(QT_NO_DEBUG) && !defined(QT_FORCE_ASSERTS)
#    define Q_ASSERT(cond) static_cast<void>(false && (cond))
#  else
#    define Q_ASSERT(cond) ((cond) ? static_cast<void>(0) : qt_assert(#cond,
__FILE__, __LINE__))
#  endif
#endif

The expression static_cast<void>(false && (cond)) is produced when qt thinks
this Q_ASSERT should be disabled. Since it this is a nop Q_ASSERT should not
containing anything that has side effects as a parameter.
FIXED-IN:1.9.1

M  +5    -1    src/defmac.h

https://invent.kde.org/sdk/kdiff3/commit/18d3db26dea575c1b8f418d23ccb93ecc9df026f

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to