https://bugs.kde.org/show_bug.cgi?id=436738

--- Comment #17 from pbs3...@googlemail.com ---
> So I open a file, add an annotation, save it as filea.pdf then move the
> annotation around and save it as fileb.pdf. Your algorithm would think it's
> the same file.

Yes, except in the rare case that the annotation coordinates lie in a 4kB
chunk. This indeterminacy alone is enough to make me not like my partial
hashing scheme, unless it can be guaranteed that the annotation data will
always be included.

Maybe the hash of the whole file is the way to go. Possibly falling back to
partial hashing only for huge files.

By the way, if I add and save an annotation on a huge PDF file (> 1GB), does
the whole PDF get rewritten out, or just the annotation?

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to