https://bugs.kde.org/show_bug.cgi?id=439464

Harald Sitter <sit...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
   Version Fixed In|                            |5.22.4
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/kinfocenter/commit/0e5e4
                   |                            |567141b814f67ef4e6971121ba9
                   |                            |b922b265
         Resolution|---                         |FIXED

--- Comment #5 from Harald Sitter <sit...@kde.org> ---
Git commit 0e5e4567141b814f67ef4e6971121ba9b922b265 by Harald Sitter.
Committed on 09/07/2021 at 10:31.
Pushed by sitter into branch 'master'.

unbreak about CPU value when solid is missing a product string

instead of `Processors: 4 x` one now gets `Processors: 4`, or
`Processors: 4 x Unknown Type, 12 x AMD Ryzen 5 3600X 6-Core Processor`
when some of the cores have a product and the others do not.

The latter is an incredible edge case but I suppose we best handle it
properly. It did require reshuffling of the entry though. We now list
the cores in the ctor to generate the label but only generate the values
at call time so as to localize this potential placeholder accordingly.

Meanwhile the former case ultimately lumps all processors together even
when they are actually different from a physical POV (such as the
heterogenous CPU set up of "ARM big.LITTLE"), but given the high level
overview this KCM provides there is no point in expansively trying to
figure out what the actual topology is (we do indeed not concern
ourselves with topology at all in this entry).
FIXED-IN: 5.22.4

M  +19   -7    Modules/about-distro/src/CPUEntry.cpp
M  +7    -1    Modules/about-distro/src/CPUEntry.h

https://invent.kde.org/plasma/kinfocenter/commit/0e5e4567141b814f67ef4e6971121ba9b922b265

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to