https://bugs.kde.org/show_bug.cgi?id=440382
Bug ID: 440382 Summary: Main toolbar elements messed up on (un)maximize then using split view. Product: dolphin Version: 21.07.80 Platform: Other OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: dolphin-bugs-n...@kde.org Reporter: kokok...@gmail.com CC: kfm-de...@kde.org Target Milestone: --- Created attachment 140386 --> https://bugs.kde.org/attachment.cgi?id=140386&action=edit Video of the bug SUMMARY When using split view and maximizing and unmaximizing the main dolphin window, toolbar elements got messed up. See Video attached. Offending commit: koko@Gozer# git bisect good 0cee94ce82ccb82afd0c4e22d77e251276e7a447 is the first bad commit commit 0cee94ce82ccb82afd0c4e22d77e251276e7a447 Author: Felix Ernst <fe.a.er...@gmail.com> Date: Wed Jan 6 01:38:45 2021 +0000 Fix location bar being wrongly aligned on first startup When starting Dolphin the very first time, the spacing in front of the location bar is wrong. This commit fixes this by completely updating all cached geometry every time adjustSpacing() is called. Because this happens once on a timer 100 ms after every url change, it will happen once shortly after the window is shown. At that point all geometry is where it should be and spacing calculation works as expected. The ViewContainer geometry retrieval is refactored into a small nested helper class in DolphinNavigatorsWidgetAction by the name ViewGeometriesHelper. Previously the logic of that class was divided between DolphinTabPage and DolphinNavigatorsWidgetAction. BUG: 429447 FIXED-IN: 21.04.0 src/dolphinnavigatorswidgetaction.cpp | 216 ++++++++++++++++++++-------------- src/dolphinnavigatorswidgetaction.h | 78 ++++++++---- src/dolphintabpage.cpp | 34 +----- src/dolphintabpage.h | 5 - 4 files changed, 191 insertions(+), 142 deletions(-) -- You are receiving this mail because: You are watching all bug changes.