https://bugs.kde.org/show_bug.cgi?id=440852
Zamundaaa <xaver.h...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/plas
| |ma/kwin/commit/9056eccd6241
| |223b36d899357680acd52ac6880
| |4
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #10 from Zamundaaa <xaver.h...@gmail.com> ---
Git commit 9056eccd6241223b36d899357680acd52ac68804 by Xaver Hugl, on behalf of
Erik Kurzinger.
Committed on 25/08/2021 at 12:32.
Pushed by zamundaaa into branch 'Plasma/5.22'.
platforms/drm: check wl_eglstream buffers before attaching
If a wl_eglstream buffer is attached to a surface, but then later a different
type of buffer, such as a dmabuf, is attached to the same surface, kwin will
mistakenly keep trying to acquire frames from the EGLStream associated with the
previous buffer. This can happen if an Xwayland window is made full-screen
causing it to switch to the flipping presentation path, for instance. The
result is that the window contents will no longer be updated.
Instead, the eglstream backend's loadTexture and updateTexture functions should
first pass the buffer to eglCreateStreamAttribNV. If it fails with
EGL_BAD_STREAM_KHR, that indicates it is indeed a wl_eglstream, and that we've
already associated a server-side EGLStream with it in attachStreamConsumer, so
we can proceed as usual. If it fails with EGL_BAD_ACCESS, though, that
indicates it is not a wl_eglstream and we should fall back to the parent class
which handles attaching other buffer types. If it doesn't fail at all, that
means the client tried to attach a new wl_eglstream to a surface without first
attaching the stream consumer. There's not really a great way to handle this,
so just re-use the previous EGLStream.
(cherry picked from commit 770875a76e662a1ed7728da769f8f7d019623701)
M +41 -5 src/plugins/platforms/drm/egl_stream_backend.cpp
M +4 -0 src/plugins/platforms/drm/egl_stream_backend.h
https://invent.kde.org/plasma/kwin/commit/9056eccd6241223b36d899357680acd52ac68804
--
You are receiving this mail because:
You are watching all bug changes.
