https://bugs.kde.org/show_bug.cgi?id=441206
Ahmad Samir <a.samir...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Latest Commit|https://invent.kde.org/util |https://invent.kde.org/util |ities/konsole/commit/2684bc |ities/konsole/commit/a731cd |7fa5ac0b740b3e8661c3a0ae013 |883304c2e00dce5210bc929a59d |6fde0a7 |49736c2 --- Comment #7 from Ahmad Samir <a.samir...@gmail.com> --- Git commit a731cd883304c2e00dce5210bc929a59d49736c2 by Ahmad Samir. Committed on 27/08/2021 at 12:31. Pushed by ahmadsamir into branch 'release/21.08'. Only emit empty() in SessionFinished() when in TabbedNavigation mode empty() is emitted so that MainWindow calls close() and we get rid of the colours-flashing bug when closing the last session/tab in a window, see commit bbec72250d080. However all that isn't relevant when we are in konsole Part mode, where there are no tabs or MainWindows. This fixes a crash in Dolphin when closing its window while the embedded Konsole Part is open. The crash would happen as calling ViewContainer::currentTabViewCount() would end up in the ViewSplitter code path, which is no-op in Konsole Part. To test: - Open dolphin, make sure the terminal panel isn't open to begin with - open the terminal panel - close the dolphin window while the terminal panel is open FIXED-IN: 21.08.1 (cherry picked from commit 2684bc7fa5ac0b740b3e8661c3a0ae0136fde0a7) M +7 -5 src/ViewManager.cpp https://invent.kde.org/utilities/konsole/commit/a731cd883304c2e00dce5210bc929a59d49736c2 -- You are receiving this mail because: You are watching all bug changes.