https://bugs.kde.org/show_bug.cgi?id=442079

--- Comment #4 from Oleg Solovyov <[email protected]> ---
(In reply to David Edmundson from comment #3)
> Good investigation.
> 
> Lets just set a limit on our input prompt to stop when we hit 4 keys then,
> so it's at least clear to the user.

limit is already set, I can't set more than 4 keys (with modifiers, etc.)
The problem is that only first one is stored.

e.g. if I set something like "Alt+B, Alt+F, Alt+G" it will store only "Alt+B",
silently omitting other keys.

Currently we're using int <-> QKeySequence which will definitely cause sequence
truncation.
I'd suggest using one of the following:
int        <---> QKeySequence (dumb impl)
quint128 ? <---> QKeySequence (each key [1] with modifiers [2] uses 32 bits,
use a 128bit type if exist)
int        <-X-> QKeySequence (avoid conversion and transfer )

[1] https://doc.qt.io/qt-5/qt.html#Key-enum
[2] https://doc.qt.io/qt-5/qt.html#KeyboardModifier-enum

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to