https://bugs.kde.org/show_bug.cgi?id=442457

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kwidgetsaddons/commi
                   |                            |t/8845da411bc3dc86a5135cbd3
                   |                            |e3846680d148f88
         Resolution|---                         |FIXED

--- Comment #2 from Nate Graham <n...@kde.org> ---
Git commit 8845da411bc3dc86a5135cbd3e3846680d148f88 by Nate Graham.
Committed on 16/09/2021 at 18:57.
Pushed by ngraham into branch 'master'.

Revert "Set default buttons"

This reverts commit 54d85c9898f9f23084b4bd47e262e712385aca30.

With a heavy heart, we have to revert this for now because various apps
were relying on the previous implicit assignment of default buttons, and
setting them here breaks people's muscle memory and introduces incorrect
behavior changes, such as making "Cancel" the default button in a
"Save/Don't Save/Cancel" dialog. We can revisit the situation in KF6
when it becomes okay to make breaking changes because apps are expected
to have to adapt to them.

M  +0    -9    src/kmessagebox.cpp

https://invent.kde.org/frameworks/kwidgetsaddons/commit/8845da411bc3dc86a5135cbd3e3846680d148f88

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to