https://bugs.kde.org/show_bug.cgi?id=365813
David Faure <fa...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |ASSIGNED
--- Comment #2 from David Faure <fa...@kde.org> ---
Thanks for the patch, much appreciated, I needed this to be able to work on
kdepim ;)
Tested to work, please push the change.
"could end up meaning two separate things" is already a problem, I think, when
having a module and a module-set with the same name. For instance,
kf5-extragear-build-include says
module-set kmymoney
repository kde-projects
use-modules kdiagram alkimia kmymoney
end module-set
What happens when doing "kdesrc-build kmymoney" is that it builds the
module-set, which also means one can't *just* rebuild the module alone. And,
with this patch, "options kmymoney" would always apply to the whole module-set
rather than just one module. It seems to me that module-set-options wouldn't be
ideal because it would fix the 2nd issue while "kdesrc-build kmymoney" would
still be ambiguous.
The obvious best solution to that problem is to not use module names for
module-sets, since this makes us lose flexibility. Therefore I would rename
these badly named module sets ("akonadi" could very well be "kde-pim-akonadi",
in fact that module set name is useless, maybe "module" would have been enough?
(I forgot it that would use branch-group settings...)).
And then if we make sure that we don't have conflicts anymore (=> your
suggestion of a warning sounds good), we can keep using "options" for both (so
this patch is fine).
--
You are receiving this mail because:
You are watching all bug changes.
