https://bugs.kde.org/show_bug.cgi?id=444015
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://invent.kde.org/fram
| |eworks/plasma-framework/com
| |mit/bd8c296ab79fe00e77aaf3f
| |7b38aff373d9ee6ee
--- Comment #5 from Nate Graham <n...@kde.org> ---
Git commit bd8c296ab79fe00e77aaf3f7b38aff373d9ee6ee by Nate Graham, on behalf
of Vlad Zahorodnii.
Committed on 19/10/2021 at 11:44.
Pushed by ngraham into branch 'master'.
Fix crash in WindowThumbnail::updatePaintNode()
Recently, the WindowThumbnail was changed so it properly discards the
texture provider in the releaseResources() function.
But it appears like there's a case where the releaseResources() function
can be called in the windowToTexture() function, which will result in
use after free bugs.
Based on af5a855da42c3ada2f0e802c68ad8f7c0e73b38e, it looks like the
WindowThumbnail item didn't use QQuickItem::releaseResources() to
properly release its graphics resources. It was checking whether the
texture node still has a texture. If there's no texture, it means that
the texture got discarded and it needs to be re-created; otherwise it
is okay to re-use the old texture.
With QQuickItem::releaseResources(), we don't need that workaround
anymore since QtQuick will call the releaseResources() function whenever
it wants the WindowThumbnail to discard graphics resources.
M +0 -5 src/declarativeimports/core/windowthumbnail.cpp
https://invent.kde.org/frameworks/plasma-framework/commit/bd8c296ab79fe00e77aaf3f7b38aff373d9ee6ee
--
You are receiving this mail because:
You are watching all bug changes.
