https://bugs.kde.org/show_bug.cgi?id=444883

Christoph Cullmann <cullm...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/ktexteditor/commit/b
                   |                            |357a5db49d78323a37cf14d2120
                   |                            |8b6500f06ad1
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #28 from Christoph Cullmann <cullm...@kde.org> ---
Git commit b357a5db49d78323a37cf14d21208b6500f06ad1 by Christoph Cullmann, on
behalf of Milian Wolff.
Committed on 29/12/2021 at 13:54.
Pushed by cullmann into branch 'master'.

Apply word filter on async completion models

When an async model resets itself in a delayed fashion, we showed
all its items and ignored the word at the current cursor position.
By calling `cursorPositionChanged()` from the `modelReset()` slot
in `KateCompletionWidget` we can ensure that the newly arrived
results are properly filtered too.

This is important for KDevelop where the clang provided completion
items arrive with a noticeable delay. Something changed in handling
those items in the last few months, breaking the filtering. Now the
async results are correctly filtered again and the new unit test
coverage should hopefully prevent further breakage in the future.

M  +30   -0    autotests/src/codecompletiontestmodel.cpp
M  +15   -0    autotests/src/codecompletiontestmodel.h
M  +14   -0    autotests/src/completion_test.cpp
M  +1    -0    autotests/src/completion_test.h
M  +2    -0    src/completion/katecompletionwidget.cpp

https://invent.kde.org/frameworks/ktexteditor/commit/b357a5db49d78323a37cf14d21208b6500f06ad1

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to