https://bugs.kde.org/show_bug.cgi?id=449985
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
|ma/plasma-workspace/commit/ |ma/plasma-workspace/commit/
|146ef22fcbdaf8bc4648e1fb29a |a31e4ce4ec4c0a7083b9bdfa962
|6415a524f83dd |dafec4ac8f784
--- Comment #13 from Nate Graham <n...@kde.org> ---
Git commit a31e4ce4ec4c0a7083b9bdfa962dafec4ac8f784 by Nate Graham.
Committed on 17/02/2022 at 19:23.
Pushed by ngraham into branch 'Plasma/5.24'.
Lock/login themes: stop adjusting shadows based on color scheme
Right now we change the intensity of shadows based on the color scheme's
text color, but with a property called "lightBackground". This indicates
that we wanted to do it based on the background color itself, but did
not or could not, so settled on using the text color as a proxy. However
this is wrong; there is no relationship between the active color
scheme's text color and the color of the background image.
Even if we could or did fix that, it would probably still be wrong,
because using lighter shadows on a genuinely light background would
result in worse contrast and readability, especially if the light
background was very visually busy.
For these reasons, in most other places, we have since settled on the
mantra of "shadows should be black", and this commit makes the lock and
login screens follow that convention as well.
FIXED-IN: 5.24.2
(cherry picked from commit 146ef22fcbdaf8bc4648e1fb29a6415a524f83dd)
M +1 -7 lookandfeel/contents/lockscreen/LockScreenUi.qml
M +2 -13 sddm-theme/Main.qml
https://invent.kde.org/plasma/plasma-workspace/commit/a31e4ce4ec4c0a7083b9bdfa962dafec4ac8f784
--
You are receiving this mail because:
You are watching all bug changes.
