https://bugs.kde.org/show_bug.cgi?id=254779

--- Comment #5 from David Zaslavsky <diaz...@ellipsix.net> ---
I've completed the new patches (subject to coding style cleanup or design
changes), incorporating the feedback from above. I wound up not changing the
code design of the model, but I did add some comments to explain why the model
used is preferable to alternatives, and I also refactored some code into
methods to make it less confusing. So I have two commits: one that implements
these preliminary changes, and another one that adds the key validity filtering
on top of that.

The thing is, as far as I can tell I can't upload the second patch to
Reviewboard because it's based on a commit that's not in the kgpg git
repository. Should I upload the first patch and wait for it to be reviewed and
added to the repository before submitting the next one, or submit one patch
with all the changes together, or upload one or both patches here, or something
else?

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to