https://bugs.kde.org/show_bug.cgi?id=414904

snx <s...@mailbox.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kxmlgui/commit/a8207
                   |                            |6a6c353509ca404157237f61c6a
                   |                            |28b37d3e

--- Comment #8 from snx <s...@mailbox.org> ---
Git commit a82076a6c353509ca404157237f61c6a28b37d3e by snooxx 💤.
Committed on 16/03/2022 at 20:11.
Pushed by ahmadsamir into branch 'master'.

KShortcutsEditorDelegate: Fix HiDPI rendering of indicator arrows

Even with HiDPI rendering enabled in applications, the standard
"Configure Keyboard Shortcuts" dialog would still show pixelated
indicator arrows in the "Shortcut" and "Alternate" columns.

This is because the respective pixmap is only scaled up, but not
rendered appropriately sized from the beginning.

Setting the pixmap's `devicePixelRatio` and increasing its size fixes
the issue. `option.rect` is in device independent pixels, and therefore
should be kept as is.

Note: In order for the arrows to still get drawn in the right place,
additional fixes in `KExtendableItemDelegate` (i.e. the base class) are
necessary, see frameworks/kitemviews!10.

Test Plan:
  - Launch `QT_SCALE_FACTOR=1.7 ./bin/kxmlguiwindowtest`.
  - Open "Configure Keyboard Shortcuts" dialog.
  - Arrows in "Shortcut" column should not be pixelated anymore, for
    both their expanded and collapsed states.
  - Test with `-style Fusion` and other scaling factors, too.

M  +7    -2    src/kshortcutseditordelegate.cpp

https://invent.kde.org/frameworks/kxmlgui/commit/a82076a6c353509ca404157237f61c6a28b37d3e

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to