https://bugs.kde.org/show_bug.cgi?id=438309
tcanabr...@kde.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Latest Commit| |https://invent.kde.org/util
| |ities/konsole/commit/fca0f4
| |f9d7de1158fb421bb28136bfff5
| |fe11a7c
--- Comment #7 from tcanabr...@kde.org ---
Git commit fca0f4f9d7de1158fb421bb28136bfff5fe11a7c by Tomaz Canabrava, on
behalf of ivan tkachenko.
Committed on 25/05/2022 at 11:15.
Pushed by tcanabrava into branch 'master'.
Rename "fallback" profile to Built-in
* Rename everything related to built-in profile both in code and UI.
* Unified style for [Read-only] and [Default] badges in profile
manager's list model.
* Change --fallback-profile option to --builtin-profile.
* Backward compatibility: yes. If a user happened to name their
profile "Built-in", it would continue to work as normal, and even
load with `--profile "Built-in"` command line flag. It will let them
modify any property including Name; but changing the name back
to "Built-in" shows a warning and reverts the change as usual.
* Remove "This option is a shortcut for" sentence. While it is still
technically possible to pass built-in profile's magic path, this
option is not a shortcut, nor implemented as such.
* Delete extra naming conditions in ProfileManager::changeProfile,
because they could never be triggered anyway, due to pre-flight
checks in EditProfileDialog::isProfileNameValid. Automatic unique
profile names generation has been done even earlier in either
SessionController or ProfileSettings. Just as before, users will
continue experiencing a generic "A profile with the name \"%1\"
already exists." message.
Tests:
* Improve test for uncreatable file name of built-in profile.
* Add backward compatibility test for loading existing profile
named "Built-in" which also references real built-in as its parent.
M +2 -2 doc/manual/index.docbook
M +6 -11 src/Application.cpp
M +48 -10 src/autotests/ProfileTest.cpp
M +2 -1 src/autotests/ProfileTest.h
M +1 -1 src/autotests/TerminalInterfaceTest.cpp
M +17 -10 src/profile/Profile.cpp
M +5 -6 src/profile/Profile.h
M +18 -38 src/profile/ProfileManager.cpp
M +12 -13 src/profile/ProfileManager.h
M +5 -5 src/profile/ProfileModel.cpp
M +3 -3 src/session/SessionController.cpp
M +7 -7 src/settings/ProfileSettings.cpp
M +2 -2 src/widgets/EditProfileDialog.cpp
https://invent.kde.org/utilities/konsole/commit/fca0f4f9d7de1158fb421bb28136bfff5fe11a7c
--
You are receiving this mail because:
You are watching all bug changes.
