https://bugs.kde.org/show_bug.cgi?id=367730

Martin Gräßlin <mgraess...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/kwin
                   |                            |/9c5f972c6a5a8f0ebd06db3249
                   |                            |d8edd1ace7686c

--- Comment #3 from Martin Gräßlin <mgraess...@kde.org> ---
Git commit 9c5f972c6a5a8f0ebd06db3249d8edd1ace7686c by Martin Gräßlin.
Committed on 25/08/2016 at 09:47.
Pushed by graesslin into branch 'master'.

Forward x11 raw pointer buttons to PointerInputRedirection

Summary:
The raw pointer button events intercepted in the XInput2 input filter
get sent through the Platform to the PointerInputRedirection. This
makes the PointerInputRedirection track the pointer button state and
emit the signals for button changed and axis changed.

These signals are used by the modifier-only shortcut detection to
determine whether the shortcut should trigger.

On X11 the "normal" input handling doesn't use the InputRedirection
and the emitted signals are not consumed by anything else. As
PointerInputRedirection is not inited the events are not forwarded
to the input filter, thus won't be processed by other parts and
won't interfere with the normal event processing on X11.

Given that it also doesn't matter that the input filter does not
apply the left-handed setting. The internal tracking will have a
wrong mouse button, but nothing is going to do decisions based on
the value of the pressed mouse button. For the moment all we are
interested in is that a button is pressed.

Test Plan:
Pressed meta, clicked, scrolled, released meta: launcher
did not open. Pressed meta, released meta: launcher opened

Reviewers: #kwin, #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D2506

M  +58   -0    plugins/platforms/x11/standalone/xinputintegration.cpp
M  +6    -4    pointer_input.cpp

http://commits.kde.org/kwin/9c5f972c6a5a8f0ebd06db3249d8edd1ace7686c

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to