https://bugs.kde.org/show_bug.cgi?id=454226
Ahmad Samir <a.samir...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/fram
| |eworks/kio/commit/c34f934e5
| |8911b0ab64fa9cdbbb662f69ab8
| |dfda
Resolution|--- |FIXED
Status|REPORTED |RESOLVED
Version Fixed In| |5.98
--- Comment #2 from Ahmad Samir <a.samir...@gmail.com> ---
Git commit c34f934e58911b0ab64fa9cdbbb662f69ab8dfda by Ahmad Samir.
Committed on 19/08/2022 at 15:35.
Pushed by ahmadsamir into branch 'master'.
FileUndoManager: for copyjob only add undo if it copied something
Test plan, before applying this patch:
- copy some files/dirs in dolphin, note the Edit menu now has an "undo copy"
action
- copy the same files/dirs to the same destination again, you should see
the copy conflict dialog
- enable "apply to all" and click "skip", nothing is copied; now check the
Edit menu again, you should see the "undo copy" action still enabled,
because another undo command was added even when nothing was copied
- trigger "undo copy", nothing happens
- trigger "undo copy" again, now it's asking if you want to delete
/path/to/dest/files-you-copied-earlier from the destination
Add a unittest.
FIXED-IN: 5.98
M +57 -0 autotests/fileundomanagertest.cpp
M +1 -1 autotests/fileundomanagertest.h
M +11 -0 src/widgets/fileundomanager.cpp
https://invent.kde.org/frameworks/kio/commit/c34f934e58911b0ab64fa9cdbbb662f69ab8dfda
--
You are receiving this mail because:
You are watching all bug changes.
