https://bugs.kde.org/show_bug.cgi?id=344392
--- Comment #10 from Thomas Schmitt <scdbac...@gmx.net> --- I had a look at the spots where Debian's source search finds IMAGE_ISO. Whether IMAGE_RAW is really needed seems to depend only on the tolerance towards the size test in http://sources.debian.net/src/k3b/2.0.3a-2/src/misc/k3bimagewritingdialog.cpp/?hl=463#L463 If isoFs() or isoFs.open() throw an exception then it might be necessary to skip this test. In this case it would be necessary to introduce IMAGE_RAW or let IMAGE_UNKNOWN take over the role of IMAGE_RAW. It seem, though, that IMAGE_UNKNOWN also serves as "Image Unsuitable". So one better introduces a new value. -------------------------------------------------------------------------- http://sources.debian.net/src/k3b/2.0.3a-2/src/misc/k3bimagewritingdialog.cpp/?hl=887#L887 would be ok for IMAGE_RAW, too. I.e. if( currentImageType() == IMAGE_ISO || currentImageType() == IMAGE_RAW) { http://sources.debian.net/src/k3b/2.0.3a-2/src/misc/k3bimagewritingdialog.cpp/?hl=244#L244 http://sources.debian.net/src/k3b/2.0.3a-2/src/misc/k3bimagewritingdialog.cpp/?hl=249#L249 would need mapping and reverse mapping for IMAGE_RAW. Actually the existing text "Plain data image" would rather match IMAGE_RAW than IMAGE_ISO. http://sources.debian.net/src/k3b/2.0.3a-2/src/misc/k3bimagewritingdialog.cpp/?hl=1087#L1087 would need a display text for IMAGE_RAW. Like "opaque". http://sources.debian.net/src/k3b/2.0.3a-2/src/misc/k3bimagewritingdialog.cpp/?hl=1048#L1048 would then need a case "opaque" and make use of the reverse mapping defined by L249. http://sources.debian.net/src/k3b/2.0.3a-2/src/misc/k3bimagewritingdialog.cpp/?hl=845#L845 would have to allow growisofs for IMAGE_RAW as for IMAGE_ISO. http://sources.debian.net/src/k3b/2.0.3a-2/src/misc/k3bimagewritingdialog.cpp/?hl=858#L858 one would have to add IMAGE_RAW to the "||" list. http://sources.debian.net/src/k3b/2.0.3a-2/src/misc/k3bimagewritingdialog.cpp/?hl=867#L867 Same as L858. http://sources.debian.net/src/k3b/2.0.3a-2/src/misc/k3bimagewritingdialog.cpp/?hl=874#L874 Same as L858. http://sources.debian.net/src/k3b/2.0.3a-2/src/misc/k3bimagewritingdialog.cpp/?hl=548#L548 must stay as is, because it determines whether the file is really an ISO 9660 filesystem image. It will thus determine the difference between IMAGE_ISO and IMAGE_RAW. http://sources.debian.net/src/k3b/2.0.3a-2/src/misc/k3bimagewritingdialog.h/?hl=81#L81 would define the new enum value IMAGE_RAW. -- You are receiving this mail because: You are watching all bug changes.
