https://bugs.kde.org/show_bug.cgi?id=437272

Harald Sitter <sit...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REPORTED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/plasma-pa/commit/e87f2b1
                   |                            |3c8701a5d332f7a84fe1a0c3442
                   |                            |04cbfb

--- Comment #8 from Harald Sitter <sit...@kde.org> ---
Git commit e87f2b13c8701a5d332f7a84fe1a0c344204cbfb by Harald Sitter.
Committed on 11/10/2022 at 10:12.
Pushed by sitter into branch 'master'.

don't crash when the server doesn't respond

inside libpulse a non-reply (e.g. caused by a timeout) results in info
being a nullptr. when that happens simply skip over the callback. when
this happens chances are the server crashed or is otherwise defunct so
we won't be able to do much about this anyway

easy to test by attaching to both plasmashell and pulseaudio and
interrupting the latter when the former calls
pa_context_get_server_info. this results in the reply timeout getting
hit -> nullptr callback.

it is unclear if we can somehow recover from this but in lieu of a
reliable real world test case for this we at least shouldn't crash on
nullptr access.
Related: bug 454647

M  +6    -0    src/context.cpp

https://invent.kde.org/plasma/plasma-pa/commit/e87f2b13c8701a5d332f7a84fe1a0c344204cbfb

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to