https://bugs.kde.org/show_bug.cgi?id=460415

--- Comment #16 from Jin Liu <ad.liu....@gmail.com> ---
(In reply to Jin Liu from comment #14)
> (In reply to Nate Graham from comment #12)
> > Sounds like something in our settings migration script went wrong,
> > unfortunately.
> 
> I think it's not in the settings migration script, but because of the
> fontSize's default value 10 can be too small in some screens.
> 
> If we want to keep digital clock's look unchanged from 5.25 to 5.26, with
> custom font set in 5.25, then I think there're 3 options:
> 
> 1. When migrated from 5.25, has fontSize set to a secret value (e.g. -1), so
> that the QML code will use custom font and auto size, exactly as in 5.25.
> This is bad, because we can't configure this in 5.26. It'll be only
> available for widgets migrated from 5.25, but not for newly created widgets.
> 
> 2. When migrated from 5.25, the migration script calculates a suitable
> fontSize according to the panel height in config file.
> This is too difficult due to the complexity in digital clock's layout code.
> 
> 3. When migrated from 5.25, has fontSize set to a secret value (e.g. -1).
> Then the QML code, when first run in 5.26, do layout in autosize mode, and
> write the calculated font size back to config file (can I write config in
> QML?).
> The custom font still won't resize with the panel, but at least widgets
> migrated from 5.25 should look unchanged (until the user resizes the panel).
> This is the most feasible. However, it has no effect for those users already
> upgraded to 5.26. And it adds more to the already complicated QML code. So
> I'm unsure if it shall be done...

Oh I just realized there's another, very simple option:
4. When migrating from 5.25, the migration script sets the font size not to the
default 10, but to a very large value (or at least larger than the panel
height). Then the font will autofit to the panel, similar to 5.25.
cons:
1) Too late for users already upgraded.
2) The config dialog looks a bit strange with a very large sample text.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to