https://bugs.kde.org/show_bug.cgi?id=434317

Daniel Vrátil <dvra...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/plasma-firewall/commit/8
                   |                            |bb9853f7fc6ddc8fd72d7bf4079
                   |                            |713aa36008c6
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Daniel Vrátil <dvra...@kde.org> ---
Git commit 8bb9853f7fc6ddc8fd72d7bf4079713aa36008c6 by Daniel Vrátil.
Committed on 19/10/2022 at 15:48.
Pushed by dvratil into branch 'master'.

Allow IP addresses with netmask in advanced rule editor

Especially for firewall configuration, it's very much useful to be
able to allow or block subnets (e.g. I want to allow all traffic
originating on trusted part of my home network). Both UFW and
firewalld do accept IP addresses with netmask, so it is just about
allowing them in the input's validtors.

I decided to replace the regular expressions with a custom QValidator
subclass, which uses lib'c inet_pton() to validate the entered IP
address and can also handle optional netmasks.
CHANGELOG: Allow IP addresses with netmask in advanced rule editor

M  +2    -0    CMakeLists.txt
A  +3    -0    autotests/CMakeLists.txt
A  +72   -0    autotests/ipvalidatortest.cpp     [License: GPL(3+eV) GPL(v3.0)
GPL(v2.0)]
M  +2    -0    kcm/core/CMakeLists.txt
A  +107  -0    kcm/core/ipvalidator.cpp     [License: GPL(3+eV) GPL(v3.0)
GPL(v2.0)]
A  +31   -0    kcm/core/ipvalidator.h     [License: GPL(3+eV) GPL(v3.0)
GPL(v2.0)]
M  +2    -0    kcm/kcm.cpp
M  +3    -7    kcm/package/contents/ui/IpTextField.qml

https://invent.kde.org/plasma/plasma-firewall/commit/8bb9853f7fc6ddc8fd72d7bf4079713aa36008c6

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to