https://bugs.kde.org/show_bug.cgi?id=367756

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/plas
                   |                            |ma-workspace/df4387a21f6eb5
                   |                            |ede255ea148143122ae4d5ae9c

--- Comment #6 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit df4387a21f6eb5ede255ea148143122ae4d5ae9c by David Edmundson.
Committed on 09/09/2016 at 11:46.
Pushed by davidedmundson into branch 'Plasma/5.7'.

Fix some status notifier items not appearing

Summary:
Set the initial values for all the things
This is important as Plasma::DataModel has an unsolvable bug
When it gets data with a new key it tries to update the  QAIM roleNames
>From QML this achieves absolutely nothing as there is no signal to tell
QQmlDelegateModel to reload the roleNames in QQmlAdapatorModel
No matter if the row changes or the model refreshes
This means it does not re-evaluate what bindings exist (watchedRoleIds)
and we get properties that don't bind for this or any future SNI.

The main source of this problem is syncStatus can occur before
refreshCallback; but whilst that's easy to guard against, there's still
multiple if{} blocks that don't set various keys in refreshCallback()
which would all need changing too. This seemed cleaner and easier to
manage.
Related: bug 366283

Reviewers: #plasma, mart

Reviewed By: mart

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2613

M  +29   -0    dataengines/statusnotifieritem/statusnotifieritemsource.cpp

http://commits.kde.org/plasma-workspace/df4387a21f6eb5ede255ea148143122ae4d5ae9c

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to