https://bugs.kde.org/show_bug.cgi?id=402376

Fushan Wen <qydwhotm...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
                   |ma/plasma-desktop/commit/7f |ma/plasma-desktop/commit/17
                   |1c5184d5ad75485504a56bee3bc |eb382aa86107bbc39cb02c708a2
                   |11a8225bb26                 |71f28cb07c3
             Status|ASSIGNED                    |RESOLVED
   Version Fixed In|5.26                        |5.27

--- Comment #31 from Fushan Wen <qydwhotm...@gmail.com> ---
Git commit 17eb382aa86107bbc39cb02c708a271f28cb07c3 by Fushan Wen.
Committed on 02/11/2022 at 16:38.
Pushed by fusionfuture into branch 'master'.

applets/taskmanager: port away from custom drag handler

Qt Quick Drag is more reliable compared to the custom drag handler
because Qt Quick Drag will consider some corner conditions, like
cancelling drag when QQuickItem becomes invisible or disabled. Qt Quick
Drag only accepts string data and will unconditionally convert all
mime data in Drag.mimeData to QString, so a workaround is added.

DragHelper becomes a QQuickItem because when the current virtual
dekstop changes, the current dragged task can disappear, so the drag
will fail. The helper item is used to store drag data and actually
perform the drag, so drag can still work after the task item disappears.

TapHandler is added to Task item because `DragHandler` will blocck
MouseArea from receiving left click events, but TapHandler can still
work normally.

See also: https://bugreports.qt.io/browse/QTBUG-71922
FIXED-IN: 5.27

M  +48   -40   applets/taskmanager/package/contents/ui/Task.qml
M  +4    -1    applets/taskmanager/package/contents/ui/main.qml
M  +21   -61   applets/taskmanager/plugin/draghelper.cpp
M  +5    -22   applets/taskmanager/plugin/draghelper.h

https://invent.kde.org/plasma/plasma-desktop/commit/17eb382aa86107bbc39cb02c708a271f28cb07c3

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to