https://bugs.kde.org/show_bug.cgi?id=377923

--- Comment #5 from LTHR <lanthrus...@gmail.com> ---
And while I was looking through GroupDialog.qml I found another bug. 

to see the bug set: 
a. task grouping set to at least "By program name" (irrelevant though)
b. clicking grouped text set to "Show textual list" 

open 5 konsoles, they should be stacked and popuped as 5 terminals normally
when clicked on konsole icon in the task bar
now open any 2 identical tasks that would stack into one group say chromium 

And now the bug: 
First click on konsole icon - 5 items would popup normally
Now click again on konsole icon - 5 items would close normally 
And now click on Chromium icon - you will see that the popup opens with 2
chromium tasks but the height of 
this popup would be the same as the height of the previous grouping popup that
contained 5 konsoles - an ugly looking thing 

How to fix it: 
1. override the system org.kde.plasma.taskmanager with a the local copy like
with the previous fix or skip this if you already
have a copy of it in your
~/.local/share/plasma/plasmoids/org.kde.plasma.taskmanager/
2. open
~/.local/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/GroupDialog.qml
 

find 
    onVisualParentChanged: {
        if (visible && visualParent) {
            attachModel();
        } else {
            visible = false;
        }
    }

  and change it to 

    onVisualParentChanged: {

// Fixed 
        updateSize();

        if (visible && visualParent) {
            attachModel();
        } else {
            visible = false;
        }
    }

that's not all, find 


    onVisibleChanged: {
        if (visible && visualParent) {
            _oldAppletStatus = plasmoid.status;
            plasmoid.status = PlasmaCore.Types.RequiresAttentionStatus;

            attachModel();

            groupDialog.requestActivate();
            mouseHandler.forceActiveFocus();
        } else {
            plasmoid.status = _oldAppletStatus;
            visualParent = null;
            groupRepeater.model = undefined;
            groupFilter.model = undefined;
            groupFilter.rootIndex = undefined;
        }
    }

and change it to 

    onVisibleChanged: {

// Fixed 
        updateSize();

        if (visible && visualParent) {
            _oldAppletStatus = plasmoid.status;
            plasmoid.status = PlasmaCore.Types.RequiresAttentionStatus;

            attachModel();

            groupDialog.requestActivate();
            mouseHandler.forceActiveFocus();
        } else {
            plasmoid.status = _oldAppletStatus;
            visualParent = null;
            groupRepeater.model = undefined;
            groupFilter.model = undefined;
            groupFilter.rootIndex = undefined;
        }
    }

and that will fix the annoying bug with the wrong height of the window that
allocates stacked (grouped) tasks

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to