https://bugs.kde.org/show_bug.cgi?id=368581
--- Comment #3 from Martin Gräßlin <mgraess...@kde.org> --- Git commit 4235871667f402a6fdd52f91865f74c618d5c400 by Martin Gräßlin. Committed on 14/09/2016 at 08:25. Pushed by graesslin into branch 'master'. Remove not-wanted modifiers prior to evaluating global shortcuts Summary: When triggering global shortcuts we are more interested in the hold keys than the currently active modifiers. E.g. capslock should not be seen as "shift is hold". Similar we need to remove consumed modifiers. Shift+5 is % and not Shift+% - the shift modifier is consumed and needs to be removed from shortcut evaluation. To support this we need to have the actual state directly from xkbcommon. Thus a new method is added which exposes the modifiers relevant for global shortcut matching. In addition on every key press all consumed modifiers are calculated and kept so that they can be used for shortcut matching. In addition a workaround is added for Backtab. Similar workaround exists in kglobalaccel for X11. The problem is that our shortcuts are stored incorrectly: Shift+Tab instead of Backtab. Thus a mapping back is required. To make everything worse KWin registers the wrong key sequence "Alt+Shift+Backtab" which doesn't make any sense and is broken on X11 at least. The workaround supports both special cases. The one for Backtab should be turned into Shift+Tab and also KWin's special case of adding shift to backtab. Reviewers: #kwin, #plasma_on_wayland, bshah Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D2768 M +0 -1 autotests/integration/globalshortcuts_test.cpp M +0 -1 autotests/integration/tabbox_test.cpp M +24 -7 globalshortcuts.cpp M +1 -1 input.cpp M +38 -0 keyboard_input.cpp M +3 -0 keyboard_input.h http://commits.kde.org/kwin/4235871667f402a6fdd52f91865f74c618d5c400 -- You are receiving this mail because: You are watching all bug changes.
