https://bugs.kde.org/show_bug.cgi?id=368419

--- Comment #2 from Julian Seward <jsew...@acm.org> ---
Keno, thank you for the patch.   It looks OK, apart from this fragment

+   case VKI_PERF_EVENT_IOC_SET_FILTER: {
+      char *filter = (char *)ARG3;
+      PRE_MEM_READ("ioctl(VKI_PERF_EVENT_IOC_SET_FILTER)",
+        (Addr)ARG3, VG_(strnlen)(filter, VKI_PAGE_SIZE)+1);
+      break;
+   }

If I interpret this correctly, ARG3 is a C style zero-terminated string that
the syscall
reads.  Is that correct?

If so, there's already a macro for that: PRE_MEM_RASCIIZ.  I think you want
something like  PRE_MEM_RASCIIZ(ioctl(VKI_PERF_EVENT_IOC_SET_FILTER).filter",
ARG3).

Can you redo the patch and re-test it?  Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to