https://bugs.kde.org/show_bug.cgi?id=460058

Tiar <tamtamy.tym...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/krita/commit/485e586f6
                   |                            |bdde3afff121d72f93def5327d5
                   |                            |1def

--- Comment #3 from Tiar <tamtamy.tym...@gmail.com> ---
Git commit 485e586f6bdde3afff121d72f93def5327d51def by Agata Cacko.
Committed on 28/02/2023 at 21:49.
Pushed by tymond into branch 'master'.

Fix disabled Link to Image in Ref Tool after drag-and-drop

Before this commit, there was no way to link the new reference image
to the original file, because Krita were forgetting the url.
This commit fixes that.

Notes:

- you can only choose Link to Image after adding the new reference
image. If you still use the Embed in .kra option and save and reopen,
then the location will be forgotten and there won't be a way to Link it
to Image again. (possible improvement: don't forget the location).

- in theory, the image displayed in Krita might be different before
and after saving and reopening, because before it will be loading the
file from clipboard, and the code there is pretty complicated (it
doesn't always go the same way as loading from url). To prevent issues,
just keep it as "Embed as .kra".

- removed "d->embed = false" in setFilename() and added
ref->setEmbed(false) in the loading visitor instead, because then the
responsibilities of parts of the code are more clear.

M  +0    -1    libs/ui/KisReferenceImage.cpp
M  +9    -0    libs/ui/KisView.cpp
M  +1    -0    plugins/impex/libkra/kis_kra_load_visitor.cpp

https://invent.kde.org/graphics/krita/commit/485e586f6bdde3afff121d72f93def5327d51def

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to