https://bugs.kde.org/show_bug.cgi?id=467390

ratijas <m...@ratijas.tk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram
                   |eworks/qqc2-desktop-style/c |eworks/qqc2-desktop-style/c
                   |ommit/9dadd05de66a135ea0c3c |ommit/7bff5123264ab1f312229
                   |66c6bb554ab22ec6a67         |4c95bd1fab40fb0a6d3

--- Comment #4 from ratijas <m...@ratijas.tk> ---
Git commit 7bff5123264ab1f3122294c95bd1fab40fb0a6d3 by ivan tkachenko.
Committed on 31/03/2023 at 22:59.
Pushed by ratijas into branch 'kf5'.

CheckIndicator: Allow exclusive buttons to be detected via their ButtonGroup

This is a bit wasteful, as it creates a ButtonGroup attached object for
every menu item that does not have it. But it works. Unfortunately,
there is no better approach, as if ButtonGroup is bound to an item
later than this binding is established, we won't know about it.

All components using CheckIndicator, except MenuItem, were modified to
override this new more advanced heuristic with a fixed elementType, so
they don't waste memory on attached objects, and always have
predictable appearance.

See also: https://invent.kde.org/frameworks/kirigami/-/merge_requests/1014

M  +1    -0    org.kde.desktop/CheckBox.qml
M  +1    -0    org.kde.desktop/CheckDelegate.qml
M  +6    -1    org.kde.desktop/CheckIndicator.qml
M  +1    -0    org.kde.desktop/RadioButton.qml
M  +1    -0    org.kde.desktop/RadioDelegate.qml
A  +135  -0    tests/exclusive-menuitem.qml     [License: GPL(v2.0+)
LGPL(v3.0)]

https://invent.kde.org/frameworks/qqc2-desktop-style/commit/7bff5123264ab1f3122294c95bd1fab40fb0a6d3

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to