https://bugs.kde.org/show_bug.cgi?id=469383

Ingo Klöcker <kloec...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.23.1
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/pim/
                   |                            |messagelib/commit/925db3260
                   |                            |235192df76d6585e6e01ee9973e
                   |                            |d1cf
         Resolution|---                         |FIXED

--- Comment #3 from Ingo Klöcker <kloec...@kde.org> ---
Git commit 925db3260235192df76d6585e6e01ee9973ed1cf by Ingo Klöcker, on behalf
of Ingo Klöcker.
Committed on 05/05/2023 at 14:30.
Pushed by kloecker into branch 'release/23.04'.

Fix references to message parts in encrypted messages

For a content node in the decrypted mime tree of an encrypted message
content()->index() gives a wrong "relative" index inside the decrypted
mime tree. NodeHelper::fromHREF() which is used to get the content node
for the reference has no idea that is need to look inside the decrypted
message and returns the content node of the encrypted message
corresponding to the reference which is most likely the encrypted message
part. As a result importing an OpenPGP key or a vCard attached to an
encrypted message failed because the wrong message part was passed to
the corresponding URL handlers.
Using (a simpler overload of) NodeHelper::asHREF() (i.e. the counter part
for NodeHelper::fromHREF()) for generating the reference fixes those
problems.

I have verified that this change is safe for all users of
MessagePart::makeLink (which all live in kdepim-addons) and I have tested
that it fixes importing OpenPGP keys and vCards attached to encrypted
messages.
FIXED-IN: 5.23.1

M  +1    -1    mimetreeparser/src/messagepart.cpp
M  +5    -0    mimetreeparser/src/nodehelper.cpp
M  +3    -0    mimetreeparser/src/nodehelper.h

https://invent.kde.org/pim/messagelib/commit/925db3260235192df76d6585e6e01ee9973ed1cf

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to