https://bugs.kde.org/show_bug.cgi?id=369175
--- Comment #29 from Carl Love <c...@us.ibm.com> --- Created attachment 101332 --> https://bugs.kde.org/attachment.cgi?id=101332&action=edit Patch to fix missing fnptr_to_fnentry() wrapper function calls for clean and dirty helpers The attached patch fixes the missing fnptr_to_fnentry() calls for the clean and dirty calls. This patch is based on patch 101296 by Mark Wielaard but with the fnptr_to_fentry() call added to all of the other clean and dirty handlers where it was missing. Note, the order of the arguments in the function calls was also changed but that is just a "cosmetic" change The fnptr_to_fnentry() fix was tested and verified on a Power 7 (Big endian) system by applying patch 101299. The patch basically allows us to test the control flow for the bcdadd and bcdsub instructions without actually generating the bcdadd or bcdsub instructions on a Power 7. Instead of the bcdadd and bcdsub instructions being generated, the vand instruction which is supported by Power 7 is generated. With patch 101299, the bug in the clean helper was verified on a big endian system. Then when the fnptr_to_fentry() fix (patch 101296) was applied the clean helper executes correctly. The full regtest suite has been run with the attached patch applied to the current upstream code base on a Power 8 Big endian and Power 8 Little endian systems. The regtest suite on the patched upstream code has been tested and verified on an ISA 3.0 Little endian simulator. The ISA 3.0 Big endian test is currently still running. Unfortunately, building Valgrind from scratch and running the regtest literally takes all day. Please review the patch and let me know if you see any issues. If everyone approves the patch and the ISA 3.0 Big endian test passes, I will commit the fix. The fix will need to get staged for the upcoming Valgrind release. -- You are receiving this mail because: You are watching all bug changes.
