https://bugs.kde.org/show_bug.cgi?id=471361
Bug ID: 471361
Summary: Mouse Mark effect remove previous mark works only
after second stroke
Classification: Plasma
Product: kwin
Version: unspecified
Platform: Other
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: effects-various
Assignee: kwin-bugs-n...@kde.org
Reporter: ash...@linuxcomp.ru
Target Milestone: ---
When removing previous mark, the first stroke does not remove mark.
STEPS TO REPRODUCE
1. Draw some mark (shift + meta + move mouse), then release all buttons.
2. Try to remove previous mark (press and hold shift + meta, then press and
release F12).
Observed: Mark not deleted. Expected: Mark should be deleted.
3. While still holding shift + meta, try to remove mark again (press and
release F12).
Observed: Mark is deleted.
Well, actually, first F12 stroke _does_ remove mark. You can see it, if you did
not yet finished marking, and press F12, it will delete current mark. However,
if you are not currently drawing, and just want to delete previous mark,
hitting shift + meta before F12 already creates a mark (it is yet zero length).
And from user perspective of view, it feels like first stroke did not work.
My guess is that here
https://invent.kde.org/plasma/kwin/-/blob/master/src/plugins/mousemark/mousemark.cpp#L193
the check `!drawing.isEmpty()` maybe should be something like `len(drawing) ==
1`.
KDE Plasma Version: 5.27.6
KDE Frameworks Version: 5.107.0
Qt Version: 5.15.10
Graphics Platform: Wayland
ADDITIONAL INFORMATION
When deleting that zero length stroke, you can see the other marks become a bit
smoother.
--
You are receiving this mail because:
You are watching all bug changes.
