https://bugs.kde.org/show_bug.cgi?id=467910
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |6.0
Resolution|UPSTREAM |FIXED
Latest Commit| |https://invent.kde.org/plas
| |ma/powerdevil/-/commit/e1e7
| |4f37ea6ba4d3450ae79ede25a7c
| |ac1dd9a84
--- Comment #2 from Nate Graham <n...@kde.org> ---
Git commit e1e74f37ea6ba4d3450ae79ede25a7cac1dd9a84 by Nate Graham.
Committed on 13/08/2023 at 19:29.
Pushed by ngraham into branch 'master'.
Make minimum screen brightness not always be 0
With some drivers, a value of 0 disables the screen backlight
completely, which is almost certainly not what the user wanted. The
Battery & Brightness widget has logic to handle this and instead make
1 the minimum brightness for screens. But Powerdevil does not, and as a
result, the behaviors differ between adjusting the brightness using the
widget and using the keyboard's "brightness down" key. This is
inconsistent and weird.
This commit unifies the behaviors by adding logic to Powerdevil to match
what the widget does.
Arguably this is working around a driver bug, but insisting that all
graphics driver bugs be fixed is not practical due to their diversity
and frequent regressions. And the Battery & Brightness widget already
has such a workaround to prevent users whose graphics drivers don't
work as they should from experiencing this issue, so not doing the same
here is inconsistent.
FIXED-IN: 6.0
M +4 -4 daemon/powerdevilbrightnesslogic.cpp
M +14 -0 daemon/powerdevilbrightnesslogic.h
M +6 -0 daemon/powerdevilscreenbrightnesslogic.cpp
M +1 -0 daemon/powerdevilscreenbrightnesslogic.h
https://invent.kde.org/plasma/powerdevil/-/commit/e1e74f37ea6ba4d3450ae79ede25a7cac1dd9a84
--
You are receiving this mail because:
You are watching all bug changes.
