https://bugs.kde.org/show_bug.cgi?id=435235

--- Comment #12 from Igor Kushnir <igor...@gmail.com> ---
(In reply to Igor Kushnir from comment #10)
> I think this bug is in KIO, because the KIO::copy() documentation -
> https://api.kde.org/frameworks/kio/html/classKIO_1_1CopyJob.html,
> https://api.kde.org/frameworks/kio/html/namespaceKIO.html#a8e3118adc0bb43d03ad15d67bc3d335c
>  - doesn't forbid calling
> KIO::CopyJob::exec(). Have you considered reporting the KIO bug upstream?
KJob::isStartedWithExec() was introduced in
https://commits.kde.org/kcoreaddons/afe26afee3dfaebdaedeebadb2e0c860c1893093 to
warn about calling exec() on a KIO job. But the warning itself hasn't been
implemented in KIO. In any case, the best possible likely outcome is that the
job would fail semi-silently (with a qWarning) instead of freezing KDevelop. A
similar bug in Kate that inspired KJob::isStartedWithExec() was fixed by not
calling exec() in
https://commits.kde.org/kate/ded94b65ff4fbba38f123a19bcd650e67de711ff. So I
believe doing the same, i.e. abandoning synchronous calls, in KDevelop is the
right solution. Unfortunately, this correct solution appears to be much harder
to implement in KDevelop than in Kate, because the offending exec() calls are
located inside deeply nested helper functions, such as KDevelop::copyUrl().

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to