https://bugs.kde.org/show_bug.cgi?id=472864

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/plasma-workspace/-/commi
                   |                            |t/f6628194399d3347c328732ff
                   |                            |bf79f601ff7e89c
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Nate Graham <n...@kde.org> ---
Git commit f6628194399d3347c328732ffbf79f601ff7e89c by Nate Graham.
Committed on 31/08/2023 at 00:24.
Pushed by ngraham into branch 'master'.

Don't return QIcons for Kicker models

When the models return QIcons, the result is icon data that's recolored
by KIconLoader according to the system color scheme. However these
returned QIcons may be displayed by Kirigami.Icon instances in Kickoff
and other applets using a different Plasma color scheme from the
systemwide one, and then the icons will be colored incorrectly.

We can fix the issue by removing usages of QIcon and instead returning
the icon names or file paths directly; Kirigami.Icon can handle them
both internally and perform the recoloring correctly for all plasma and
systemwide colorscheme combinations.

M  +2    -2    applets/kicker/plugin/abstractentry.cpp
M  +1    -2    applets/kicker/plugin/abstractentry.h
M  +5    -22   applets/kicker/plugin/appentry.cpp
M  +4    -4    applets/kicker/plugin/appentry.h
M  +1    -2    applets/kicker/plugin/computermodel.cpp
M  +3    -3    applets/kicker/plugin/fileentry.cpp
M  +1    -1    applets/kicker/plugin/fileentry.h
M  +1    -2    applets/kicker/plugin/recentusagemodel.cpp
M  +2    -2    applets/kicker/plugin/rootmodel.cpp
M  +1    -1    applets/kicker/plugin/rootmodel.h
M  +0    -1    applets/kicker/plugin/runnermatchesmodel.cpp
M  +2    -2    applets/kicker/plugin/simplefavoritesmodel.cpp
M  +3    -3    applets/kicker/plugin/systementry.cpp
M  +1    -1    applets/kicker/plugin/systementry.h

https://invent.kde.org/plasma/plasma-workspace/-/commit/f6628194399d3347c328732ffbf79f601ff7e89c

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to