https://bugs.kde.org/show_bug.cgi?id=339863
Felix Ernst <felixer...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit|https://commits.kde.org/oxy |https://invent.kde.org/fram
|gen-icons5/221951952d22ae8d |eworks/kwidgetsaddons/-/com
|4b8b9d8dc90af53cf8401a92 |mit/e5ef8184db0733b944cb7a3
| |c9ee1cf239035921b
Status|ASSIGNED |RESOLVED
--- Comment #66 from Felix Ernst <felixer...@kde.org> ---
Git commit e5ef8184db0733b944cb7a3c9ee1cf239035921b by Felix Ernst, on behalf
of Felix Ernst.
Committed on 07/09/2023 at 13:35.
Pushed by felixernst into branch 'master'.
Fix file rating being unreadable in certain themes
Typically, a rating on a file is represented by five stars in a
row. If the first 3 stars are filled and the other 2 aren't, that
represents a 3/5 star rating.
When a theme only provides the filled stars (i.e. "rating") icon
but no unfilled stars (i.e. "rating-unrated") icon, KRatingPainter
would always paint all five stars as filled no matter if the actual
rating was 1/5 or 5/5 because the automatic fallback of the
"rating-unrated" icon is the "rating" icon as stated by the icon
theme spec.
This commit fixes this by having KRatingPainter use a generated
replacement "rating-unrated" icon (a de-saturated and grey-scaled
"rating" icon), if the theme does not provide a "rating-unrated"
icon already.
M +10 -6 src/kratingpainter.cpp
https://invent.kde.org/frameworks/kwidgetsaddons/-/commit/e5ef8184db0733b944cb7a3c9ee1cf239035921b
--
You are receiving this mail because:
You are watching all bug changes.
