https://bugs.kde.org/show_bug.cgi?id=474307
Bug ID: 474307
Summary: Assigning Tokens "A", "B", ... does not work anymore
in viewer mode
Classification: Applications
Product: kphotoalbum
Version: GIT master
Platform: openSUSE
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: Viewer
Assignee: kpab...@willden.org
Reporter: schleth...@web.de
Target Milestone: ---
STEPS TO REPRODUCE
1. view a few images in viewer mode (full screen or window)
2. hit some letter key to assign a token for one or some of them
3. check whether the token has been assigned
OBSERVED RESULT
None of the tokens has been assigned. (This worked before!)
EXPECTED RESULT
The images should have the respective tokens assigned.
SOFTWARE/OS VERSIONS
KPA: v5.11.0-92-g28815029
Linux/KDE Plasma:
KDE Plasma Version:
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8
ADDITIONAL INFORMATION
I did a git bisect and found the bad commit [Hi Jesper! :-)]:
3a130ed45089c1b043bea8834a23be0438b4ee17 is the first bad commit
commit 3a130ed45089c1b043bea8834a23be0438b4ee17
Author: Jesper K. Pedersen <jesper.peder...@kdab.com>
Date: Mon Jul 24 10:08:51 2023 +0200
Support annotating images from the viewer
.reuse/dep5 | 4 +
CHANGELOG.md | 3 +-
CMakeLists.txt | 21 +-
DB/CategoryCollection.cpp | 12 ++
DB/CategoryCollection.h | 10 +-
DB/GlobalCategorySortOrder.cpp | 74 +++++++
DB/GlobalCategorySortOrder.h | 49 +++++
DB/ImageDB.cpp | 2 +-
DB/XML/FileReader.cpp | 17 ++
DB/XML/FileReader.h | 1 +
DB/XML/FileWriter.cpp | 11 +
DB/XML/FileWriter.h | 1 +
MainWindow/Window.cpp | 3 +-
MainWindow/Window.h | 1 -
Utilities/DescriptionUtil.cpp | 3 +
Viewer/AnnotationHandler.cpp | 126 ++++++++++++
Viewer/AnnotationHandler.h | 46 +++++
Viewer/CursorVisibilityHandler.cpp | 79 ++++++++
Viewer/CursorVisibilityHandler.h | 34 ++++
Viewer/ImageDisplay.cpp | 55 +----
Viewer/ImageDisplay.h | 7 -
Viewer/SelectCategoryAndValue.cpp | 212 ++++++++++++++++++++
Viewer/SelectCategoryAndValue.h | 38 ++++
Viewer/SelectCategoryAndValue.ui | 175 ++++++++++++++++
Viewer/SpeedDisplay.cpp | 88 --------
Viewer/SpeedDisplay.h | 41 ----
Viewer/TransientDisplay.cpp | 78 ++++++++
Viewer/TransientDisplay.h | 42 ++++
Viewer/ViewerWidget.cpp | 397 ++++++++++++++++++++-----------------
Viewer/ViewerWidget.h | 48 +++--
Viewer/documentation.h | 2 +-
doc/annotation-mode.png | Bin 0 -> 149131 bytes
doc/assign-macro-add-new-value.png | Bin 0 -> 20497 bytes
doc/assign-macro-overview.png | Bin 0 -> 51638 bytes
doc/assign-macro-step1.png | Bin 0 -> 20504 bytes
doc/assign-macro-step2.png | Bin 0 -> 14579 bytes
doc/draw-on-image.png | Bin 401217 -> 0 bytes
doc/setting-properties.docbook | 21 +-
doc/viewer.docbook | 227 ++++++++-------------
39 files changed, 1374 insertions(+), 554 deletions(-)
create mode 100644 DB/GlobalCategorySortOrder.cpp
create mode 100644 DB/GlobalCategorySortOrder.h
create mode 100644 Viewer/AnnotationHandler.cpp
create mode 100644 Viewer/AnnotationHandler.h
create mode 100644 Viewer/CursorVisibilityHandler.cpp
create mode 100644 Viewer/CursorVisibilityHandler.h
create mode 100644 Viewer/SelectCategoryAndValue.cpp
create mode 100644 Viewer/SelectCategoryAndValue.h
create mode 100644 Viewer/SelectCategoryAndValue.ui
delete mode 100644 Viewer/SpeedDisplay.cpp
delete mode 100644 Viewer/SpeedDisplay.h
create mode 100644 Viewer/TransientDisplay.cpp
create mode 100644 Viewer/TransientDisplay.h
create mode 100644 doc/annotation-mode.png
create mode 100644 doc/assign-macro-add-new-value.png
create mode 100644 doc/assign-macro-overview.png
create mode 100644 doc/assign-macro-step1.png
create mode 100644 doc/assign-macro-step2.png
delete mode 100644 doc/draw-on-image.png
--
You are receiving this mail because:
You are watching all bug changes.
