https://bugs.kde.org/show_bug.cgi?id=461872

--- Comment #14 from Andrei Rybak <rybak....@gmail.com> ---
Just some thinking out loud:

> Before adding an item to the menu, we check if any items for the same device 
> ID exists and
> we remove them, so I don't see how this could happen.

I took a look at the git log, this logic comes from 2014:
https://invent.kde.org/network/kdeconnect-kde/-/commit/90e9ded92655c26fbbe521982289998183631a50#b5e40816c0cc22bf4a042c2010f48a3423f93b0e_84_85

> the problem. Method `KFilePlacesModel::closestItem` doesn't return the hidden 
> entries

Ten months ago (https://bugs.kde.org/show_bug.cgi?id=461872#c1) I commented
that I _had_ to hide section 'Devices':

> This gets so bad, that I just have to hide the "Devices" section in Dolphin 
> completely.
> 
> Question: is it possible that this is a Dolphin bug?

Maybe there was some other compounding bug (not in Dolphin, maybe in KIO?) that
caused the entries not to be deleted? On the screenshot from matrix43547 --
https://bugs.kde.org/attachment.cgi?id=153763 -- the device names are in color
of a "shown" section.

> All links to tag v5.108.0 in the frameworks/kio repository, because that's 
> the version of KDE Frameworks I'm currently using.

This part of method `KFilePlacesModel::closestItem` hasn't changed since
version 5.103.0, which is visible in video
https://bugsfiles.kde.org/attachment.cgi?id=156717 which was recorded on
2023-02-25:

   
https://invent.kde.org/frameworks/kio/-/blob/v5.103.0/src/filewidgets/kfileplacesmodel.cpp#L733

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to