https://bugs.kde.org/show_bug.cgi?id=366594

Michael Pyne <mp...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |http://commits.kde.org/kdes
                   |                            |rc-build/14fc9bb282ef1cf5cb
                   |                            |3b73d2b40083186fd303a1
         Resolution|---                         |FIXED
   Version Fixed In|                            |16.08
      Latest Commit|http://commits.kde.org/kdes |http://commits.kde.org/kdes
                   |rc-build/14fc9bb282ef1cf5cb |rc-build/c9d32735a4ff11c5a3
                   |3b73d2b40083186fd303a1      |0654976e2bb539c0886710
   Version Fixed In|16.08                       |16.10

--- Comment #7 from Michael Pyne <mp...@kde.org> ---
Git commit 14fc9bb282ef1cf5cb3b73d2b40083186fd303a1 by Michael Pyne.
Committed on 08/10/2016 at 19:34.
Pushed by mpyne into branch 'master'.

Allow module-set validation to pass in 'options' overrides.

This show allow 'ignore-modules' to work in 'options' blocks (at least,
it does in my testing).

FIXED-IN:16.08

M  +8    -5    modules/ksb/Application.pm

http://commits.kde.org/kdesrc-build/14fc9bb282ef1cf5cb3b73d2b40083186fd303a1

--- Comment #8 from Michael Pyne <mp...@kde.org> ---
Git commit c9d32735a4ff11c5a30654976e2bb539c0886710 by Michael Pyne.
Committed on 08/10/2016 at 19:38.
Pushed by mpyne into branch 'master'.

Allow options blocks to override unseen module-sets.

In other words, we separate parsing of options blocks from whether
existing modules or module-sets have already been seen. Instead we
decide later (when expanding module-sets or modules) whether there are
any relevant options blocks to apply (this is the 'deferred option'
handling).

Now you should be able to declare options blocks that contain options
appropriate for module-sets, even if no module-set is defined with that
name (e.g. if you're doing weirdness with 'include' declarations).

This does require that you don't use the same name for modules and for
module-sets, but that is essentially already a requirement anyways.
There's no good way to always disambiguate that.
FIXED-IN:16.10

M  +17   -53   modules/ksb/Application.pm
M  +33   -14   modules/ksb/ModuleResolver.pm

http://commits.kde.org/kdesrc-build/c9d32735a4ff11c5a30654976e2bb539c0886710

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to